Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove special handling for Prettier #104

Merged
merged 2 commits into from
Nov 6, 2023
Merged

feat: Remove special handling for Prettier #104

merged 2 commits into from
Nov 6, 2023

Conversation

jhnns
Copy link
Member

@jhnns jhnns commented Nov 6, 2023

Since we don't include formatting rules anymore, we also don't need to include special configs/rules for Prettier setups

BREAKING CHANGE: The prettier- prefix has been removed from all preset files: peerigon/presets/prettier-typescript.js becomes peerigon/presets/typescript.js, peerigon/presets/prettier-typescript-react.js becomes peerigon/presets/typescript-react.js and peerigon/presets/prettier-typescript-node.js becomes peerigon/presets/typescript-node.js

@jhnns jhnns merged commit 068b731 into beta Nov 6, 2023
2 checks passed
@jhnns jhnns deleted the remove-prettier branch November 6, 2023 15:56
github-actions bot pushed a commit that referenced this pull request Nov 6, 2023
# [37.0.0-beta.2](v37.0.0-beta.1...v37.0.0-beta.2) (2023-11-06)

### Features

* Remove special handling for Prettier ([#104](#104)) ([068b731](068b731))

### BREAKING CHANGES

* The `prettier-` prefix has been removed from all preset files: `peerigon/presets/prettier-typescript.js` becomes `peerigon/presets/typescript.js`, `peerigon/presets/prettier-typescript-react.js` becomes `peerigon/presets/typescript-react.js` and `peerigon/presets/prettier-typescript-node.js` becomes `peerigon/presets/typescript-node.js`
Copy link

github-actions bot commented Nov 6, 2023

🎉 This PR is included in version 37.0.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Nov 6, 2023
# [37.0.0](v36.0.0...v37.0.0) (2023-11-06)

### Features

* Add new base rules ([#105](#105)) ([10d01ed](10d01ed))
* New beta release ([c358189](c358189))
* Remove deprecated formatting rules ([#103](#103)) ([deab90a](deab90a))
* Remove special handling for Prettier ([#104](#104)) ([068b731](068b731))

### BREAKING CHANGES

* Some new base rules have been introduced which might produce linting errors.
* The `prettier-` prefix has been removed from all preset files: `peerigon/presets/prettier-typescript.js` becomes `peerigon/presets/typescript.js`, `peerigon/presets/prettier-typescript-react.js` becomes `peerigon/presets/typescript-react.js` and `peerigon/presets/prettier-typescript-node.js` becomes `peerigon/presets/typescript-node.js`
* All formatting rules have been removed as they have been deprecated by ESLint (see eslint.org/blog/2023/10/deprecating-formatting-rules). We won't switch to @stylistic/eslint-plugin-js as code formatting should be done by Prettier nowadays.
Copy link

github-actions bot commented Nov 6, 2023

🎉 This PR is included in version 37.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant